OGPカードのリンク先を投稿されたURLに変更する by ramdos0207 · Pull Request #5152 · traPtitech/traQ_S-UI

ramdos0207 · 2026-05-17T11:39:42Z

概要

なぜこの PR を入れたいのか

OGPカードのリンク先としてog:urlを使うのは間違っていると思われる
主な文脈：https://q.trap.jp/messages/019d1988-4202-75bc-beed-a9c09b16ee95

動作確認の手順

https://cover-corp.com/news/detail/c2026032201 などのOGPカードを踏む

UI 変更部分のスクリーンショット

（UI変更なし）

PR を出す前の確認事項

（機能の追加なら）追加することの合意がチームで取れている
- clientを変更すべきかは要議論です
動作確認ができている
自分で一度コードを眺めて自分的に問題はなさそう

見てほしいところ・聞きたいことなど

Summary by CodeRabbit

Refactor
- OGPプレビューリストの内部データ構造を整理し、各プレビュー項目へURLを明確に渡すようにしました。
- タイトル未設定のプレビューは一覧から除外されるよう安定化しました。
- 描画キーの付与を改善して重複や誤対応を防止しました。
- 見た目や操作感に変更はありません。

github-actions · 2026-05-17T11:39:50Z

Preview (prod) → https://5152-prod.traq-preview.trapti.tech/
Preview (dev) → https://5152-dev.traq-preview.trapti.tech/

coderabbitai · 2026-05-17T11:39:54Z

📝 Walkthrough

Walkthrough

MessageOgpList.vue で ogpItems 計算プロパティを導入し、externalUrls から各 URL とその OGP データをペアにした配列を生成。テンプレートはこれを反復し、子コンポーネント MessageOgpListItem.vue に url と ogpData を分離した props として渡すよう変更しました。

Changes

OGP item rendering refactor

Layer / File(s)	Summary
OGP items 計算ロジックとテンプレート統合 `src/components/Main/MainView/MessageElement/Embeddings/MessageOgpList.vue`, `src/components/Main/MainView/MessageElement/Embeddings/MessageOgpListItem.vue`	`MessageOgpList.vue` で `flatMap` を使用した新しい `ogpItems` computed を実装し、各アイテムに URL と OGP データをペアで含める。テンプレートを更新して `ogpItems` を反復し、`MessageOgpListItem` に `url` と `ogpData` を個別に渡す。`MessageOgpListItem.vue` は新しい `url` prop を定義して、テンプレートバインディングで `ogpData.url` の代わりに使用。

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	PR のタイトルは、OGP カードのリンク先を投稿された URL に変更するという主要な変更内容を明確に反映しており、簡潔で具体的です。
Description check	✅ Passed	PR 説明は必須セクション（概要、PR を入れたい理由、動作確認手順、確認事項）をすべて含みながらも、概要セクションが空欄となっています。
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch change-ogp-card-link

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/components/Main/MainView/MessageElement/Embeddings/MessageOgpList.vue`:
- Around line 4-5: v-for の key が現在 :key="item.url"
だと同一URLが複数ある場合に重複してしまうため、MessageOgpList.vue の ogpItems をループしている箇所で key
を一意化してください（例: item.url にループインデックスや item.id を組み合わせる）。具体的には v-for="(item, index)
in ogpItems" のようにインデックスを取得し、:key に item.url と index か、もし利用可能なら固有の識別子（item.id
など）を組み合わせて一意のキーを生成するよう修正してください。

🪄 Autofix (Beta)

✅ Autofix completed

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cc3f24cf-bc96-4560-85a1-5061d36fe317

📥 Commits

Reviewing files that changed from the base of the PR and between 66b58a0 and 35d454a.

📒 Files selected for processing (2)

src/components/Main/MainView/MessageElement/Embeddings/MessageOgpList.vue
src/components/Main/MainView/MessageElement/Embeddings/MessageOgpListItem.vue

codecov · 2026-05-17T11:41:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.43%. Comparing base (66b58a0) to head (3b3155b).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5152   +/-   ##
=======================================
  Coverage   62.43%   62.43%           
=======================================
  Files         108      108           
  Lines        3109     3109           
  Branches      635      635           
=======================================
  Hits         1941     1941           
  Misses       1058     1058           
  Partials      110      110

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coderabbitai · 2026-05-17T11:42:08Z

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Fixes Applied Successfully

Fixed 1 file(s) based on 1 unresolved review comment.

Files modified:

src/components/Main/MainView/MessageElement/Embeddings/MessageOgpList.vue

Commit: b04da5ea0648da56eb00860e8d4820f190d93479

The changes have been pushed to the change-ogp-card-link branch.

Time taken: 2m 5s

Fixed 1 file(s) based on 1 unresolved review comment. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>

uni-kakurenbo

みま
した
(一点だけコメントしてます)

uni-kakurenbo · 2026-05-17T13:42:14Z

-    .filter(isDefined)
-    .filter(o => o.title)
+const ogpItems = computed(() =>
+  props.externalUrls.flatMap(url => {


今までどおり filter いっぱい書くほうが素直で読みやすい気がしました (が、好みではあると思うのでお好みで直したり直さなかったりしてください)

coderabbitai

🧹 Nitpick comments (1)

src/components/Main/MainView/MessageElement/Embeddings/MessageOgpList.vue (1)
34-34: 💤 Low value

型注釈は不要です。

externalUrls は props で string[] 型として定義されているため、url の型は既に推論されています。明示的な : string 注釈は冗長です。
♻️ 簡略化案
   props.externalUrls
-    .map((url: string) => {
+    .map((url) => {
       const ogpData = ogpDataMap.value.get(url)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/Main/MainView/MessageElement/Embeddings/MessageOgpList.vue` at
line 34, Props externalUrls is already typed as string[], so remove the
redundant explicit type annotation in the map callback; change the arrow
function from .map((url: string) => { ... }) to .map((url) => { ... }) so url is
inferred from externalUrls and the code is simpler.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/components/Main/MainView/MessageElement/Embeddings/MessageOgpList.vue`:
- Line 34: Props externalUrls is already typed as string[], so remove the
redundant explicit type annotation in the map callback; change the arrow
function from .map((url: string) => { ... }) to .map((url) => { ... }) so url is
inferred from externalUrls and the code is simpler.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 73dcd047-3699-4872-9b46-20f61f9298d4

📥 Commits

Reviewing files that changed from the base of the PR and between b04da5e and 3b3155b.

📒 Files selected for processing (1)

src/components/Main/MainView/MessageElement/Embeddings/MessageOgpList.vue

OGPカードのリンク先を投稿されたURLに変更する

35d454a

ramdos0207 linked an issue May 17, 2026 that may be closed by this pull request

OGPカードのリンク先を og:url の値ではなく実際のURLにする #5151

Open

coderabbitai Bot reviewed May 17, 2026

View reviewed changes

Comment thread src/components/Main/MainView/MessageElement/Embeddings/MessageOgpList.vue Outdated

fix: apply CodeRabbit auto-fixes

b04da5e

Fixed 1 file(s) based on 1 unresolved review comment. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>

uni-kakurenbo approved these changes May 17, 2026

View reviewed changes

fix: use filter

3b3155b

coderabbitai Bot reviewed May 27, 2026

View reviewed changes

ramdos0207 requested a review from uni-kakurenbo May 27, 2026 12:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OGPカードのリンク先を投稿されたURLに変更する#5152

OGPカードのリンク先を投稿されたURLに変更する#5152
ramdos0207 wants to merge 3 commits into
masterfrom
change-ogp-card-link

ramdos0207 commented May 17, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

github-actions Bot commented May 17, 2026

Uh oh!

coderabbitai Bot commented May 17, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

codecov Bot commented May 17, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 17, 2026 •

edited

Loading

Uh oh!

uni-kakurenbo left a comment

Uh oh!

uni-kakurenbo May 17, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ramdos0207 commented May 17, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

概要

なぜこの PR を入れたいのか

動作確認の手順

UI 変更部分のスクリーンショット

PR を出す前の確認事項

見てほしいところ・聞きたいことなど

Summary by CodeRabbit

Uh oh!

github-actions Bot commented May 17, 2026

Uh oh!

coderabbitai Bot commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov Bot commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitai Bot commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixes Applied Successfully

Uh oh!

uni-kakurenbo left a comment

Choose a reason for hiding this comment

Uh oh!

uni-kakurenbo May 17, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ramdos0207 commented May 17, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 17, 2026 •

edited

Loading

coderabbitai Bot left a comment •

edited

Loading

codecov Bot commented May 17, 2026 •

edited

Loading

coderabbitai Bot commented May 17, 2026 •

edited

Loading